PMT angular analysis - #49
Open
dtaghayor wants to merge 4 commits into
Open
Conversation
… and outside the expected Cherenkov cone
Contributor
|
Please can you pull the latest version of the repo to fix the merge conflicts in the init.py file. |
Contributor
|
Instead of linking the geometry package to your local area could you use the gitsubmodule linked - see the Michel electron code for an example for how to do this |
# Conflicts: # analysis_tools/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the PMT angular analysis example notebook and the main script, in addition to some changes to init.py