chore(profile-plot): Enable backwards compatibility for profile plots after RELEASE 3.23 - #223
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe profile plot code now assigns a default label when summarized data lacks a ChangesProfile Plot Adjustments
Estimated code review effort: 2 (Simple) | ~8 minutes Merge Risk: ⚪ Minimal · up to Legacy profile inputs retain the endogenous label, and the fixed line width is compatible with the supported ggplot2 version. No material merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the labels in the plot, Comment |
|
Failed to generate code suggestions for PR |
Motivation and Context
#193
A while back, we added the "LABEL" column to ProteinLevelData to account for the protein turnover use case where there would be heavy-labeled summaries and light-labeled summaries. However, old saved datasets became incompatible for processing as a result with
dataProcessPlotswith profile plots.Changes
aes+sizeparameterTesting
Please describe any unit tests you added or modified to verify your changes.
Checklist Before Requesting a Review
Motivation and solution
Older saved datasets may not contain
LABELinProteinLevelData. The plot-processing code now uses"Endogenous"as the label for run-summary data whenLABELis absent. The profile plot also uses a fixed line width, avoiding thesizeaesthetic mapping for lines.Changes
.plotProfile, map the run-summaryLABELthroughraw_label_mapwhen the summarized data containsLABEL; otherwise, use"Endogenous"..makeSummaryProfilePlot, remove the line-level mapping fromsizetoanalysisand setgeom_line(linewidth = 0.5). The point layers retain their existing size mapping.Unit tests
tests/tinytest.R, but the available evidence does not show that this change adds or modifies tests.Coding guidelines