test(vtable): cover filtered updateRecords persistence - #5327
Merged
Merged
Conversation
Preserve regression coverage for source-record updates after filters are cleared. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateFilterRules->updateRecords-> clear filters withsyncRecordOperationsToSourceRecordsmodifiedCellsfield in source recordsCloses #4794
Test plan
a68f06035because source Employee 2 remains unchangedrushx test --runInBand __tests__/data-update/listTable-data-events.test.ts(16 tests passed)rushx test --runInBand(80 suites, 388 tests passed)rushx compilerush build --to @visactor/vtableBugserver note
The attempted photo case was removed because both the newest available build (
1.0.0.4553) and oldest available build (1.0.0.4350) passed. Bugserver no longer exposes a pre-fix build, so the case could not distinguish the regression and was not valid evidence.🤖 Generated with Claude Code