Skip to content

test(vtable): cover filtered updateRecords persistence - #5327

Merged
fangsmile merged 2 commits into
developfrom
fix/issue-4794-filtered-update-records
Sep 21, 2026
Merged

fangsmile merged 2 commits into
developfrom
fix/issue-4794-filtered-update-records

Conversation

@fangsmile

Copy link
Copy Markdown
Contributor

Summary

  • add an exact regression test for updateFilterRules -> updateRecords -> clear filters with syncRecordOperationsToSourceRecords
  • add a runnable debug demo that preserves the updated name and modifiedCells field in source records
  • document that the production behavior was introduced by Feat/support cell values change #4913 while closing the missing regression coverage

Closes #4794

Test plan

  • Verify the regression test fails on pre-fix commit a68f06035 because source Employee 2 remains unchanged
  • Run rushx test --runInBand __tests__/data-update/listTable-data-events.test.ts (16 tests passed)
  • Run full rushx test --runInBand (80 suites, 388 tests passed)
  • Run rushx compile
  • Run VTable source ESLint (0 errors; existing warnings only)
  • Run rush build --to @visactor/vtable
  • Verify the debug demo in Chrome at desktop and narrow viewports
  • Pass repository pre-push package tests

Bugserver note

The attempted photo case was removed because both the newest available build (1.0.0.4553) and oldest available build (1.0.0.4350) passed. Bugserver no longer exposes a pre-fix build, so the case could not distinguish the regression and was not valid evidence.

🤖 Generated with Claude Code

Preserve regression coverage for source-record updates after filters are cleared.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
@fangsmile
fangsmile merged commit 5cf9030 into develop Sep 21, 2026
7 of 8 checks passed
@fangsmile
fangsmile deleted the fix/issue-4794-filtered-update-records branch September 21, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant