Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "test(vtable): cover preserving addRecords results after clearing filters",
"type": "patch",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "892739385@qq.com"
}
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,48 @@ describe('listTable data events test', () => {
expect(filterCalls).toBe(5);
});

test('addRecords under filter should preserve new records after clearing filter', () => {
table.release();
const records = [
{ name: 'Alice', age: 25, group: 'A' },
{ name: 'Bob', age: 30, group: 'B' },
{ name: 'Charlie', age: 35, group: 'A' }
];
const newRecords = [
{ name: 'David', age: 40, group: 'A' },
{ name: 'Eve', age: 45, group: 'B' }
];

table = new ListTable({
container: containerDom,
columns: [
{ field: 'name', title: 'Name' },
{ field: 'age', title: 'Age' },
{ field: 'group', title: 'Group' }
],
records,
syncRecordOperationsToSourceRecords: true
});

table.updateFilterRules([
{
filterKey: 'group',
filteredValues: ['A']
}
]);
table.addRecords(newRecords);
table.updateFilterRules([]);

expect((table.records as typeof records).map(record => record.name)).toEqual([
'Alice',
'Bob',
'Charlie',
'David',
'Eve'
]);
expect(records).toEqual(table.records);
});

test('addRecord under filter should keep relative position after clearing filter', () => {
table.release();
const records = [
Expand Down
74 changes: 74 additions & 0 deletions packages/vtable/examples/debug/issue-4607-filter-add-records.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
import * as VTable from '../../src';

interface Issue4607Window extends Window {
tableInstance?: VTable.ListTable;
issue4607Run?: () => boolean;
BUGSERVER_SCREENSHOT?: () => void;
}

const CONTAINER_ID = 'vTable';

export function createTable() {
const container = document.getElementById(CONTAINER_ID);
if (!container) {
throw new Error(`Missing #${CONTAINER_ID} container`);
}
container.style.width = '640px';
container.style.height = '360px';

const sourceRecords = [
{ name: 'Alice', age: 25, group: 'A' },
{ name: 'Bob', age: 30, group: 'B' },
{ name: 'Charlie', age: 35, group: 'A' }
];
const addedRecords = [
{ name: 'David', age: 40, group: 'A' },
{ name: 'Eve', age: 45, group: 'B' }
];

const status = document.createElement('div');
status.id = 'issue4607Status';
status.style.cssText = 'margin: 0 0 12px; font: 600 14px/1.5 sans-serif;';
status.textContent = 'RUNNING';
container.parentElement?.insertBefore(status, container);

const tableInstance = new VTable.ListTable(container, {
columns: [
{ field: 'name', title: 'Name', width: 180 },
{ field: 'age', title: 'Age', width: 120 },
{ field: 'group', title: 'Group', width: 120 }
],
records: sourceRecords,
syncRecordOperationsToSourceRecords: true
});

const runCheck = () => {
tableInstance.updateFilterRules([
{
filterKey: 'group',
filteredValues: ['A']
}
]);
tableInstance.addRecords(addedRecords);
tableInstance.updateFilterRules([]);

const names = (tableInstance.records as typeof sourceRecords).map(record => record.name);
const pass =
names.join(',') === 'Alice,Bob,Charlie,David,Eve' &&
sourceRecords.length === 5 &&
sourceRecords[3] === addedRecords[0] &&
sourceRecords[4] === addedRecords[1];

status.textContent = `${pass ? 'PASS' : 'FAIL'} | ${names.join(', ')}`;
status.style.color = pass ? '#237804' : '#a8071a';
status.style.borderLeft = `4px solid ${pass ? '#52c41a' : '#ff4d4f'}`;
status.style.paddingLeft = '8px';
(window as Issue4607Window).BUGSERVER_SCREENSHOT?.();
return pass;
};

const issueWindow = window as Issue4607Window;
issueWindow.tableInstance = tableInstance;
issueWindow.issue4607Run = runCheck;
requestAnimationFrame(runCheck);
}
4 changes: 4 additions & 0 deletions packages/vtable/examples/menu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ export const menus = [
path: 'debug',
name: 'issue-4656-fill-handle-hit-area'
},
{
path: 'debug',
name: 'issue-4607-filter-add-records'
},
{
path: 'debug',
name: 'issue-3752-large-merge-auto-height'
Expand Down
Loading