Conversation
Why: - Let charts mark numeric risk zones even when no data point falls inside them. - Keep selector bands and range annotations mutually exclusive and explicit. What: - Add validated range bounds and axis-aware clipped geometry for supported Cartesian charts. - Cover Builder validation, rendering, generated option docs, and runnable examples. - Fix generated preview fence whitespace and retain stable coverage floors.
Record the VSeed range-annotation feature as a patch Changeset so the fixed VSeed, VBI, and VQuery release group can advance together.
youngwinds
reviewed
Sep 24, 2026
| const issues = validation.error.issues.map((issue) => `${issue.path.join('.')}: ${issue.message}`).join('; ') | ||
| throw new Error(`${path}.range: ${issues}`) | ||
| } | ||
| if (!rangeChartTypes.has(vseed.chartType)) { |
Collaborator
There was a problem hiding this comment.
建议pipe解除图表类型依赖, 最小功能pipe, 在各个图表类型中组装;
每个pipeline已经确定图表类型了, 应该避免在pipe内根据图表类型做不同的逻辑;
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个分支是...
🔗 相关 issue 链接
暂无。
🔗 相关的 PR 链接
无。
🐞 Bugserver 用例 id
不适用。
💡 问题的背景&解决方案
现有
annotationArea.selector依赖已选中的数据点,无法准确表达“y > 10 是高危险区域”或散点图中没有数据点的矩形区域。本 PR 新增与selector互斥的range模式,使用线性数值轴的坐标上下界绘制区域:range.x、range.y至少填写一项;每项必须同时提供min/max,可用导出的AxisBoundaryEnum.Min/Max指向当前轴边界。未填写的轴铺满绘图区。selector色带行为,并在类型、Schema 和 Builder 路径校验两种模式的互斥及必填约束。验证
@visactor/vseed完整测试与覆盖率、单元测试覆盖率、类型检查及构建通过;完整覆盖率:语句/行 89.74%,分支 79.03%,函数 81.48%。/VBI/vseed/examples/features/annotationArea.html。发布计划
@visactor/vseed的 patch Changeset。pnpm changeset status确认固定版本组中的 VSeed、VBI、VQuery 都规划为 patch;当前0.6.0的目标版本为0.6.1。此 PR 不直接修改包版本,也不执行发布。☑️ 自测