Fixed Cross Product Being Zero on Mesh Export#8
Open
OliverW1986 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the mesh export workflow to use explicit Fusion 360 view orientation enums, ensure viewport updates before capturing camera vectors, and add validation for degenerate coordinate systems.
Changes:
- Replaced numeric
viewOrientationvalues withadsk.core.ViewOrientationsconstants. - Forced viewport event processing/refresh after camera changes before fitting/capturing vectors.
- Added a guard for degenerate
yVector × zVectorwhen building the alignment transform.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| app.activeViewport.fit() | ||
| # Capture Up | ||
| cam = app.activeViewport.camera | ||
| yVector = returnNormalVector(cam.eye) |
| global newTransform, inverseTransform | ||
| newTransform = adsk.core.Matrix3D.create() | ||
| origin = adsk.core.Point3D.create(0, 0, 0) | ||
| xVector = yVector.crossProduct(zVector) |
| f"yVector: {yVector.x}, {yVector.y}, {yVector.z}\n" | ||
| f"zVector: {zVector.x}, {zVector.y}, {zVector.z}") | ||
| return False | ||
| newTransform.setToAlignCoordinateSystems(origin, yVector.crossProduct(zVector), yVector, zVector, origin, |
Comment on lines
+218
to
+222
| if xVector.length < 1e-6: | ||
| ui.messageBox(f"Invalid coordinate system.\n" | ||
| f"yVector: {yVector.x}, {yVector.y}, {yVector.z}\n" | ||
| f"zVector: {zVector.x}, {zVector.y}, {zVector.z}") | ||
| return False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated a fix that gets the correct X, Y, and Z vectors when exporting the meshes, properly captures the camera positions, resets them along with a check for whether the cross product is zero, and returns false if it is.