Skip to content

Name the failing tune read check and keep captures saveable - #177

Merged
Views2k merged 3 commits into
mainfrom
fix/tune-read-check-ids
Nov 8, 2026
Merged

Views2k merged 3 commits into
mainfrom
fix/tune-read-check-ids

Conversation

@Views2k

@Views2k Views2k commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Tune read failures reported to Wisp Tools as "Current tune read failed" (3 of 59 PCs that completed a tune read on 2.7.3; one PC failed 73 times in 22 minutes without a successful read) carry no indication of which of the reader's 20 checks failed, and a car whose asset metadata lacks a part level failed the whole read.

Changes

  • Every NativeTuneRead.Require call names its check with a stable FACILITY_ITF code (TuneReadCheck), carried in the exception's HResult and written to the failure details as "Tune check: ", so the next report says which check rejected the car.
  • A car whose metadata leaves a part level unresolved no longer fails the read. The snapshot decodes with the verified part projection; IsComplete is false while a level is missing, so such a snapshot is not saved as complete.
  • Tune Performance results are read against a setup key (installed parts plus active settings) and kept by TuneCaptureService while that setup is unchanged, replacing the view-model heuristic that compared parts and fields after the fact.
  • Tune Performance profile for Steam 6.479.874.0 (vtables and seven code guards). Steam has since moved to 6.483.970.0; its profile follows separately once its live code has been verified.

Verification

  • Integration build of main plus all seven 2.7.4 fix branches on the maintainer PC: build clean, dotnet format whitespace --verify-no-changes clean.
  • PR gate selection (Test-AppBehavior.ps1 -BaseRevision main) on that build: Core 780, Telemetry 96, Update 184, Updater 76 and App 1295 tests passed, 0 failed. Tune-related classes alone: 389 App tests and 37 Core tests passed.
  • Not run: the full nightly suite (runs before the 2.7.4 tag) and any live game check.

@Views2k
Views2k merged commit 82be095 into main Nov 8, 2026
10 checks passed
@Views2k
Views2k deleted the fix/tune-read-check-ids branch November 8, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant