Repository navigation
Name the failing tune read check and keep captures saveable - #177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tune read failures reported to Wisp Tools as "Current tune read failed" (3 of 59 PCs that completed a tune read on 2.7.3; one PC failed 73 times in 22 minutes without a successful read) carry no indication of which of the reader's 20 checks failed, and a car whose asset metadata lacks a part level failed the whole read.
Changes
NativeTuneRead.Requirecall names its check with a stable FACILITY_ITF code (TuneReadCheck), carried in the exception's HResult and written to the failure details as "Tune check: ", so the next report says which check rejected the car.IsCompleteis false while a level is missing, so such a snapshot is not saved as complete.TuneCaptureServicewhile that setup is unchanged, replacing the view-model heuristic that compared parts and fields after the fact.Verification
dotnet format whitespace --verify-no-changesclean.Test-AppBehavior.ps1 -BaseRevision main) on that build: Core 780, Telemetry 96, Update 184, Updater 76 and App 1295 tests passed, 0 failed. Tune-related classes alone: 389 App tests and 37 Core tests passed.