Repository navigation
Conversation
|
Live validation found an additional gap, so I am moving this back to draft while I correct it. The client now reaches the optional |
3d03ff3 to
de66602
Compare
Entra can offer a deferrable authentication-method registration prompt. Following its explicit skip continuation lets users finish login without weakening mandatory registration policies.
de66602 to
16ef703
Compare
|
Live validation is now complete.
The updated tests cover that exact modern form request, the older GET continuation, incomplete/conflicting modern state, and mandatory |
|
Hi, this is ready for review for a week now. Since it fixes a recurring daily blocker for users on Azure AD / Microsoft optional sign-in prompts, could we get this merged into main and included in the next patch release? Thanks |
|
I know it's not optimal for everyone out there, however, we are getting by in the mean time by running a manually compiled binary that I've shared out in Slack. The build steps are easy enough, the installation is a bit less convenient due to Apple code signing, quarantine, and swapping the brew binary. Read through the commands below if it's something you're considering: Compile the binary: cd ~/code/saml2aws
CGO_ENABLED=1 GOOS=darwin GOARCH=arm64 \
go build -trimpath \
-ldflags '-s -w -X main.Version=2.36.19-team.1+84e4d24' \
-o build/team-release/saml2aws-arm64 \
./cmd/saml2aws
CGO_ENABLED=1 GOOS=darwin GOARCH=amd64 \
go build -trimpath \
-ldflags '-s -w -X main.Version=2.36.19-team.1+84e4d24' \
-o build/team-release/saml2aws-amd64 \
./cmd/saml2aws
lipo -create \
build/team-release/saml2aws-arm64 \
build/team-release/saml2aws-amd64 \
-output build/team-release/saml2aws
codesign --force --sign - build/team-release/saml2aws
codesign --verify --deep --strict build/team-release/saml2aws
lipo -info build/team-release/saml2aws
build/team-release/saml2aws --version
COPYFILE_DISABLE=1 tar -czf \
build/saml2aws-2.36.19-team.1-84e4d24-darwin-universal.tar.gz \
-C build/team-release \
saml2aws README.txt SHA256SUMS
shasum -a 256 \
build/saml2aws-2.36.19-team.1-84e4d24-darwin-universal.tar.gzInstall the binary: # Note: Access to this folder may be blocked by system
# protection, use a different folder if you are seeing issues.
cd ~/Downloads
archive="saml2aws-2.36.19-team.1-84e4d24-darwin-universal.tar.gz"
# Your SHA may be different
echo "c1542fca3bab1fa2fb78c389eac68dc4b83c1893933d215567a0d80b29c5de5e $archive" |
shasum -a 256 -c -
mkdir -p saml2aws-team
tar -xzf "$archive" -C saml2aws-team
cd saml2aws-team
shasum -a 256 -c SHA256SUMS
xattr -d com.apple.quarantine saml2aws 2>/dev/null || true
chmod +x saml2aws
dest="$(brew --prefix)/bin/saml2aws"
cp -p "$dest" "$dest.backup.$(date +%Y%m%d%H%M%S)"
cp saml2aws "$dest"
hash -r
saml2aws --version |
|
Hi @icirellik, any update? when will be this merged? |
|
Confirmed working on Windows (Azure AD provider, Authenticator number matching). Released 2.36.19 failed every time with Side note for Windows users: the PR build then hit Would be great to get this into a patch release. Thanks @icirellik for the fix! |
|
Hello @icirellik, @DiegoMontilla5, |
|
Hi @tinaboyce @srizzling, could one of you take a look at this PR? Without it, v2.36.19 fails with We're running a build of 16ef703 internally and it fixes the login. A merge and a tagged release would let everyone else drop their workarounds. Thanks! |
|
@pwmcintyre - Can you help here? |
@hegyre , hey, I'd rather not pass around binaries for a tool that handles credentials (and you probably shouldn't run one from a stranger either), but building it from this PR only takes a few minutes. Here's exactly what I did: 1. Install Go and Git if you don't have them:
Check with 2. Clone the repo and pull this PR's code. GitHub exposes every PR as a branch you can fetch by number: The 3. Build it: (On Windows use 4. Log in with the new binary from that same folder. It uses your existing (On Windows: Windows note: after MFA I got Once this gets merged and released, just upgrade your normal install and delete the PR build. A 👍 on the PR may help it get merged sooner. |
Explain why the fork exists (Versent#1541 and Versent#1516), which release file to download, how to install and unblock it on macOS and Windows, and that the fork will be archived once both PRs land upstream.
Temporary fork until this is merged: jkamleh/saml2aws v2.36.19-team.1 It combines this PR with #1516, so Windows users don't need the
Binaries are built by GitHub Actions on the fork and published with checksums. You can see the commits and build runs from the release page. They aren't signed or notarised, so you'll still need to unquarantine them on macOS or unblock them on Windows; the README covers both. |
|
Hi @tinaboyce @srizzling, any updates here? People are using forks and workarounds because this PR is not being merged. Is this project dead? |
|
@tinaboyce @srizzling Could you please review this and merge it? People are stuck. |
|
I don't work at versent anymore I don't have the rights to merge. |
@srizzling do you have any contacts there? Could you reach out to them? |
Summary
Microsoft can occasionally ask users to set up an additional sign-in method, with an option to choose Not now. saml2aws currently stops instead of completing that offered path.
This change sends Microsoft the continuation details from that page, allowing the AWS login to finish automatically. Older versions of the prompt remain supported. If Microsoft requires registration and does not offer a skip option, saml2aws still stops as before.
Why this matters
Affected users can be blocked once a day by a setup reminder even though their existing sign-in method is valid. Automating Microsoft's offered Not now action restores command-line workflows without weakening required registration policies.
The flow was validated against a live
50203registration prompt: it continued through the normal sign-in pages and returned AWS credentials.Validation
502031registration remains enforcedResolves #1540.