Repository navigation
Fix IL lookups that used the wrong kind of index - #8698
Merged
Merged
Conversation
Several MLIL and HLIL wrappers passed or interpreted the wrong kind of index, so they silently returned results for unrelated expressions. `ILReferenceSource::expr_idx` is now `instr_idx`, since core stores an instruction index there.
…pression Core maps MLIL expressions to LLIL SSA expressions, but this looked them up in non-SSA LLIL.
It asked non-SSA HLIL for the definition, but used the returned index to fetch an expression from SSA HLIL.
emesare
approved these changes
Oct 30, 2026
bdash
force-pushed
the
test_il_index_confusion
branch
from
October 30, 2026 19:05
6eca5b2 to
547ae57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several APIs passed an index to the wrong type of IL function, or passed an expression index where core expects an instruction index, or the reverse. The lookups silently returned unrelated expressions as the indexes are not strongly typed.
This PR fixes the Rust MLIL/HLIL bindings,
MediumLevelILInstruction::GetLowLevelIL, and one lookup inefi_resolver. In Rust,ILReferenceSource::expr_idxis nowinstr_idx, because it is an instruction index rather than an expression index.