Repository navigation
Avoid per-label allocations and redundant stable sorting - #28
Merged
Merged
Conversation
Store the bounded previous/current label text pair inline. Use std::sort for the final prepared draw list, whose comparator ends in unique insertion order, while preserving stable layer preparation order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Each label fade update allocates a separate temporary vector for the previous and current text of every emitted label. Those vectors never contain more than two entries. The final prepared draw list also uses stable_sort even though its comparator ends with a unique insertion_order key.
Changes
Validation
The earlier isolated allocation experiment motivated this change. End-to-end Logonomic profiling and visual validation on the deployment platforms remain outstanding; this PR does not claim an application-wide speedup.