Repository navigation
fix: include jest types explicitly for TypeScript 6 - #191
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
shubham-vapiai
approved these changes
Oct 23, 2026
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
devin/1792714439-jest-types-ts6
branch
from
October 23, 2026 00:17
196cc67 to
f721e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#190 (v3.0.1) moved the lockfile from TypeScript 5.9.2 to 6.0.3. TypeScript 6 stops auto-including
@types/*, so onmainevery test suite now fails to compile before any test runs, andmain'scipush run is red:release.ymlruns the tests too, so the v3.0.1 GitHub release can't be published until this lands.Fix
jest.config.tsnow passestypes: ['jest', 'node']to ts-jest. This only changes how ts-jest compiles the tests. The SDK build (tsc) and the emitteddist/*.d.tsare identical to before.Verification
Rebased onto current
main(ecd1d6e, package 3.0.1, TypeScript 6.0.3). The diff vsmainisjest.config.tsonly, andpackage.jsonis not touched.npm ci && npm run build && npm test -- --runInBand→ 73/73 pass. Also verified on the pre-#190 lockfile (TypeScript 5.9.2) → 73/73 pass.Link to Devin session: https://app.devin.ai/sessions/f0c8f585b41d4cbaa0459bfc8d22e211
Open in Devin Desktop: https://app.devin.ai/desktop/session/f0c8f585b41d4cbaa0459bfc8d22e211?variant=devin
Requested by: @dhruva-vapi