Repository navigation
fix: upgrade web SDK to 3.0.1 and reset widget after startup failures - #8
Open
dhruva-vapi wants to merge 2 commits into
Open
dhruva-vapi wants to merge 2 commits into
dhruva-vapi wants to merge 2 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
|
@veltsonbastien @shubham-vapiai could you review this? It bumps the widget to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Zeals reports that ~40% of web-widget calls end with
assistant-did-not-receive-customer-audio(PRISM-1083). Before 3.0.1,@vapi-ai/webcreated the backend call before it asked for the microphone. client-sdk-web#189 (released in v3.0.1) now acquires the mic first. If that fails, no call is created and the SDK emitscall-start-failedand anerrorof typemicrophone-preflight-*.Fix
@vapi-ai/webfrom2.5.2to3.0.1(exact pin) and updatepnpm-lock.yaml.src/listeners.js: oncall-start-failed,errorandcall-end, reset the button to idle and clear the active-call state, so a user who denied the mic can try again. Without this the button stays in the connecting state.dist/assetsbundles that the jsDelivr embed serves.src/listeners.test.js(6 tests) and atestscript.Verification
vite buildpasses.node --test src/listeners.test.jspasses 6/6: success, mic error, generic error, retry, cancellation.start,stop, events,setMuted,say). Nothing used by the widget changed incompatibly.Not tested: a live call with a real mic in a browser.
Note: the jsDelivr
@latestembed URL picks up the change once this merges tomaster.Link to Devin session: https://app.devin.ai/sessions/f0c8f585b41d4cbaa0459bfc8d22e211
Open in Devin Desktop: https://app.devin.ai/desktop/session/f0c8f585b41d4cbaa0459bfc8d22e211?variant=devin
Requested by: @dhruva-vapi