Repository navigation
fix: redirect bare /auth to the login page in mock and ldap auth units - #428
Open
DaniilSmirnov wants to merge 1 commit into
Open
DaniilSmirnov wants to merge 1 commit into
DaniilSmirnov wants to merge 1 commit into
Conversation
When a reverse proxy routes the whole /auth prefix (location /auth instead of the exact "location = /auth" + "location /auth/" pair) to the auth unit, the UI's redirect to /auth ended on "Cannot GET /auth" from auth-mock. The mock and ldap units now send /auth to their own login page. auth-mock exposes createApp, like auth-oauth2, so the routes can be tested. Fixes VKCOM#410
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a reverse proxy routes the whole /auth prefix (location /auth instead of the exact "location = /auth" + "location /auth/" pair) to the auth unit, the UI's redirect to /auth ended on "Cannot GET /auth" from auth-mock. The mock and ldap units now send /auth to their own login page.
auth-mock exposes createApp, like auth-oauth2, so the routes can be tested.
Fixes #410