Repository navigation
Install vhlab-toolbox-python from a GitHub archive URL instead of git+ - #12
Merged
Merged
Conversation
uv and pip shell out to a system git for git+ URLs; archive URLs are fetched over plain HTTPS, so end users no longer need git installed. The URL string must match NDI-python's exactly, or resolution fails with a conflicting-URL error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UMLSmPQyLVBfBC52mCahmk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switches the
vhlab-toolbox-pythondependency from agit+URL to a GitHub archive (zip) URL in both places that declare it (they mirror each other):pyproject.tomlrequirements.txt(what CI installs from)Why
We are building a double-click NDI installer based on
uv tool install. uv (and pip) shell out to a systemgitforgit+URLs, and many end users (especially on Windows/macOS) have no git. Archive URLs are fetched over plain HTTPS, so git is no longer needed.When two packages depend on the same package by direct URL, uv/pip require the URL strings to be identical.
ndiandvhlab-library-pythonboth depend onvhlab-toolbox-python, so the companion PR makes NDI-python use exactly the same string: Waltham-Data-Science/NDI-python#326Until both are merged, installing
ndifails with a conflicting-URL error forvhlab-toolbox-python. Whichever one merges first breaks NDI's install until the other merges, so please merge them back-to-back.Note on caching
uv caches archive URLs, so updating an existing install later to pick up new
maincommits needs--reinstall/--refresh(e.g.uv tool install --reinstall ...).Testing
ruff check vhlib/ tests/: passes.github.com/.../archive/...downloads, sopip install -r requirements.txtstopped at the download step (pip parsed the requirement fine) and the test suite could not run against the new install. This PR relies on this repo's CI for the real install + test run.🤖 Generated with Claude Code
https://claude.ai/code/session_01UMLSmPQyLVBfBC52mCahmk