Repository navigation
did2.build: key_id / positions_from (did-schema 2026-10-05) - #217
Merged
Merged
Conversation
did-schema renamed key_labels_id -> key_id and labels_from -> positions_from (signed, V_eta_study_plan.md). did2.build.key's 'LabelsFrom' becomes 'PositionsFrom', the bodies' 'KeyLabelsIds' becomes 'KeyIds', the key rule check names positions_from, and did2.build.statement gains 'KeyIds' (a statement keyed by another statement's entries, e.g. per-encounter values keyed by an encounter-onset list). Empty edges are still dropped, so callers that never set them are unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
Collaborator
Author
|
"Quick migrator tests / Migrator transform tests (no corpora)" is red: 78 tests fail. The failures are not from this PR.
The builder tests do cover this change, but they did not trigger on their own. The Generated by Claude Code |
In GitHub path filters + means 'one or more of the preceding character', so 'src/did/+did2/+build/**' never matched a +package folder and the job ran only when this workflow file itself changed (b351ea7). Escaped as \+. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did-schema renamed the edge a key takes its positions through:
key_labels_id→key_idand the key fieldlabels_from→positions_from, and the edge now points only at adata_typedocument. This was signed 2026-10-05 inV_eta_study_plan.md, did-schema PR #87. This PR follows the rename in the builders:did2.build.key:'LabelsFrom'→'PositionsFrom'(emitspositions_from).did2.build.sampledBody/opaqueBody:'KeyLabelsIds'→'KeyIds'(emitskey_id).did2.build.statementgains'KeyIds', so a statement can key by another statement's entries. The Haley import's encounters are the first use: per-encounter values keyed by a worm's encounter-onset list.private/checkRules.m) namespositions_from.testKeyPositionsFromAnotherDocument.No import or migrator wrote the old names, and empty edges are still dropped (
forward.m). Callers that never set them are unaffected by either schema.Merge order: did-schema #87 first.
test-builder.ymlruns against did-schemamain, and the new test filters itself untilmaindeclareskey_id.🤖 Generated with Claude Code
https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
Generated by Claude Code