Skip to content

v492.0 dev7#36

Open
GernotMaier wants to merge 20 commits into
mainfrom
v492.0-dev7
Open

v492.0 dev7#36
GernotMaier wants to merge 20 commits into
mainfrom
v492.0-dev7

Conversation

@GernotMaier

Copy link
Copy Markdown
Member

Minor fixes:

  • readme for Crab analysis
  • warning for hardwired values.

@GernotMaier GernotMaier self-assigned this Jun 1, 2026
@GernotMaier GernotMaier requested a review from Copilot July 11, 2026 16:30
@GernotMaier GernotMaier marked this pull request as ready for review July 11, 2026 16:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release-test tooling and documentation around Crab analysis and MC/data comparison, and improves library-loading paths by adding EVNDISPSYS support for libVAnaSum.so.

Changes:

  • Extend libVAnaSum.so discovery to include $EVNDISPSYS and update related macros/scripts/docs.
  • Adjust Crab runlist generation logic (skip non-4-telescope runs; tweak elevation bin thresholds) and update runlists/docs.
  • Add a new Python plotting utility for sensitivity diagnostics and include needed Conda dependencies.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
release_tests/utilities/parameters.C Adds EVNDISPSYS as a library search path and changes the library-load mechanism.
release_tests/sources/Crab/runlist_releaseTestingV6.dat Removes two runs from the V6 release-testing runlist.
release_tests/sources/Crab/runlist_generator_from_anasum_log.sh Skips non-4-telescope runs and updates elevation bin thresholds.
release_tests/sources/Crab/README.md Fixes the referenced script name for generating anasum products from runlists.
release_tests/sources/Crab/plot_skymaps.C Adds R__LOAD_LIBRARY directive for libVAnaSum.so.
release_tests/sources/Crab/plot_sensitivity.C Adds R__LOAD_LIBRARY directive for libVAnaSum.so.
release_tests/sources/Crab/plot_sensitivity_from_anasum_log.py New Python utility to parse anasum logs and generate diagnostic plots.
release_tests/sources/Crab/plot_lightcurves.C Adds R__LOAD_LIBRARY directive for libVAnaSum.so.
release_tests/sources/Crab/plot_energy_spectra.C Adds R__LOAD_LIBRARY directive for libVAnaSum.so.
release_tests/sources/Crab/plot_all.sh Removes unused pwd variable.
release_tests/montecarlo/mc_data_comparison/README.md Expands documentation and clarifies inputs/outputs/workflow for MC/data comparison.
release_tests/montecarlo/mc_data_comparison/compareDatawithMC.sh Minor wording/formatting fixes and a small numeric literal adjustment.
release_tests/montecarlo/mc_data_comparison/.gitignore Removes local ignore entry (moved to repo root).
release_tests/montecarlo/irf_plotting/irf_plotting.sh Adds a warning about hardwired CUT.
environment.yml Adds Python + numpy/matplotlib dependencies for the new plotting script.
.gitignore Adds tmpdir ignore at repo root.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread release_tests/utilities/parameters.C
Comment thread release_tests/utilities/parameters.C
Comment thread release_tests/sources/Crab/runlist_generator_from_anasum_log.sh
GernotMaier and others added 7 commits July 12, 2026 17:32
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants