Repository navigation
Conversation
Collaborator
|
Tested it locally and it works to fix the bug. |
| fapMeetingDecision.recommendation | ||
| ] | ||
| : null, | ||
| fapMeetingExComment: fapMeetingDecision?.commentForUser |
Collaborator
There was a problem hiding this comment.
I think there is a small mistake here that the empty string is falsy in JS, so would return null. But we probably want to stick to returning the empty string.
We'd want to use this check:
fapMeetingInComment: fapMeetingDecision?.commentForManagement != null
? stripHtml(fapMeetingDecision.commentForManagement)
: null,
Collaborator
There was a problem hiding this comment.
I think the empty string is good to go into the docs as compared to
| fapMeetingData?.[0]?.commentForUser | ||
| ? stripHtml(fapMeetingData[0].commentForUser) | ||
| fapMeetingDecision?.commentForUser | ||
| ? stripHtml(fapMeetingDecision.commentForUser) |
Collaborator
There was a problem hiding this comment.
Could do this too: fapMeetingInUserComment: fapMeetingDecision?.commentForUser != null
? stripHtml(fapMeetingDecision.commentForUser)
: '',
jekabs-karklins
self-requested a review
October 17, 2026 06:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FAP meeting decisions are stored per proposal and instrument. The spreadsheet exports previously selected the first decision for a proposal, causing all instruments for a multi-instrument proposal to display the same recommendation and comments.
Changes
Updated both the FAP results and management decision spreadsheet exports to match each decision by proposal, fap and instrument.
Tests included/Docs Updated?
New tests added for management decision export.