Repository navigation
feat: implement DateWithoutTimezone scalar and update visit registration handling to prevent timezone shifts - #1856
Open
yoganandaness wants to merge 8 commits into
Conversation
…ion handling to prevent timezone shifts
yoganandaness
requested review from
ACLay,
SourangshuSTFC,
janosbabik and
zacharyjhankin
and removed request for
a team and
ACLay
October 2, 2026 15:05
…t-registration-date
…t-registration-date
…t-registration-date
…t-registration-date
…t-registration-date
…t-registration-date
janosbabik
approved these changes
Oct 19, 2026
…t-registration-date
| const { updateVisitRegistration } = await api.updateVisitRegistration(update); | ||
| const payload: UpdateVisitRegistrationMutationVariables = { | ||
| ...update, | ||
| startsAt: update.startsAt, |
Collaborator
There was a problem hiding this comment.
We don't need this because startsAt is in update already?
zacharyjhankin
approved these changes
Oct 19, 2026
zacharyjhankin
left a comment
zacharyjhankin
left a comment
Collaborator
There was a problem hiding this comment.
Tested locally and it works, code seems to make sense
Collaborator
|
I am thinking, is the same fix needed for the call.start_call, call.end_call, call.start_review and call.end_review data fields? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimized Visit registration to be timezone agnostic. Currently, it has also been made time agnostic. ex., 2026-10-02T04:00 will be saved as 2026-10-02T00:00, since the current system supports only date submission. When the system starts supporting time selection, the same can be saved in the database. For now., the time is defaulted to the start of the day.
Motivation and Context
The current Visit registration module has multiple issues
Due to the above issues, there are multiple uncertainties surrounding the dates. ex., user officer looking at start and end date, which are different from what was submitted by the science users.
The goal is simple: When the user selects a start date and ends date, it is obvious that the dates are as per the timezone of the facility and not the user's browser location. Hence the whole workflow of the visit registration system must be timezone agnostic.
How Has This Been Tested
Both e2e and unit has been included
Fixes
Uncertainty around time and timezone issue with user visit registration submission
Changes
Depends on
Tests included/Docs Updated?