Repository navigation
feat: set page notice for specific roles - #1824
Open
Scott-James-Hurley wants to merge 16 commits into
Open
Scott-James-Hurley wants to merge 16 commits into
Scott-James-Hurley wants to merge 16 commits into
Conversation
Scott-James-Hurley
requested review from
Jonathan-Swales
and removed request for
a team
September 24, 2026 08:53
Scott-James-Hurley
requested review from
a team
and removed request for
Jonathan-Swales
September 28, 2026 10:35
simonfernandes
approved these changes
Oct 5, 2026
| /> | ||
| )} | ||
| </SimpleTabs> | ||
| <RoleFilter |
Contributor
There was a problem hiding this comment.
suggestion: We should prevent navigation if user has changed the input
Kooha-2026-10-15-15-06-49.webm
Co-authored-by: Jekabs Karklins <58165815+jekabs-karklins@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Discussion
Each role can now have it's own page notice. Derived User Officers can only edit the page notices for roles they share a tag with, base user officers can edit all page notices. There is a fallback page notice if one has not been created for a role. Please note that this PR includes only editing the page notices for roles, not displaying them to users - that will come in a proceeding PR.
Motivation and Context
Another facility at STFC is using UOP and needs to be able to display page notices specific to it's users.
How Has This Been Tested
Changes
getRolesByTagsfor fetching all roles that had specified tagsTests included/Docs Updated?