Repository navigation
feat(oneidentity): sync PEJ allowances from visit registration answers - #722
Merged
Merged
Conversation
janosbabik
marked this pull request as draft
September 11, 2026 14:35
Cancel site and system access independently, skipping missing or already-cancelled records. Add regression tests for partial cleanup and retries.
janosbabik
marked this pull request as ready for review
October 5, 2026 11:15
Send YYYY-MM-DD dates without extending the allowance end date.
updates - Validate and log the configured process timezone - Use DST-aware local calendar days for access and PEJ validity - Start system access at the current instant - Reconcile accesses independently and create missing active records - Add regression tests and update documentation
withdrawn - Reconcile allowance eligibility on visit updates without previous state - Always delete allowances during visit deletion - Add regression tests and update documentation
yoganandaness
approved these changes
Oct 15, 2026
yoganandaness
left a comment
yoganandaness
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good to me, although given my comments based on my understanding.
| - Site and system access share the visit ID in `CustomProperty04` | ||
|
|
||
| ### Access Updates | ||
| - Access records are matched by role and visit ID in `CustomProperty04`; both `Aborted` and `Unsubscribed` records are excluded |
Contributor
There was a problem hiding this comment.
When does a Record gets Aborted or Unsubscribed. Could we write here for better understanding.
|
|
||
| // Clean up each access type independently so retries can finish partial deletions. | ||
| for (const { role, name } of accessTypes) { | ||
| const accesses = personWantsOrgs.filter( |
Contributor
There was a problem hiding this comment.
I understand from the code that if the orderState is ABORTED or UNSUBSCRIBED, we dont delete it. So the record(site and system access) stays.
What happens, if the orderState is changed to ACTIVE(or the equivalent). This will give them access to site and system, even though their Visit in User Office is deleted?
Co-authored-by: Yoganandan Pandiyan <132274772+yoganandaness@users.noreply.github.com>
Ignore request status so User Officers can approve unrequested allowances.
Preserve backward compatibility for legacy visit messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.