Default token_type to Bearer on client_credentials responses - #2184
Open
DeepanshuPal wants to merge 3 commits into
Open
DeepanshuPal wants to merge 3 commits into
DeepanshuPal wants to merge 3 commits into
Conversation
Fix client_credentials sign-in to default token_type to Bearer.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2090. Implements the fix offered in my comment on that issue before it was closed. Shopify's Admin API answers a client_credentials grant with only access_token, scope and expires_in, and oauth4webapi rejects it because RFC 6749 requires token_type. This defaults it to Bearer for the client_credentials grant only and reads a comma-separated scope as a list; responses with a token_type are unchanged. Test: Shopify-shaped response (fails before, passes after) and an explicit token_type case. oauth-helpers tests 98/98; the 13 oxlint-plugin test failures in the sdk package also fail on clean main in my environment. Lint, format check and e2e not run.