tests: add new program to test ubuf_pic_blit#1205
Open
JDarnley wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test that hits all the branches (except error paths) of ubuf_pic_blit and ubuf_pic_blit_alpha. It cannot hit some branches in ubuf_pic_blit_alpha10 because of a bug when no alpha plane is present the code defaults to an 8-bit path. It also shows the bug I mentioned in #1195 regarding nv12 semi-planar pictures. These don't cause the test program to fail at the moment because I disabled the assert that would trigger.
If you agree that the expected_blit functions in the test program correctly represent what should happen then we can fix these bugs and allow the test program to generate more errors.