Repository navigation
Conversation
`_create_text_region()` and `pdfminer_elements_to_text_regions()` have no callers in the library, tests or scripts. They lost their last callers when layout merging moved to the vectorized `TextRegions`/`LayoutElements` structures (Unstructured-IO#3881, Unstructured-IO#3900); `pdfminer_elements_to_text_regions` describes itself as "a temporary solution" pending that refactor. Coverage over the full test suite shows neither ever runs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two functions in
unstructured/partition/pdf_image/pdfminer_processing.pyhave no callers anywhere in the library, tests or scripts:_create_text_region(), which scaled coordinates and built a single text region.pdfminer_elements_to_text_regions(), which convertedLayoutElementsinto a list ofEmbeddedTextRegion/ImageTextRegionobjects. Its docstring calls it "a temporary solution" until the merging logic was refactored.Both lost their last callers when layout merging moved to the vectorized
TextRegions/LayoutElementsstructures (#3881, #3900). Coverage over the full test suite confirms neither ever runs.This PR deletes both. Nothing else in the module changes:
Source,LayoutElementsandTextRegionsare still used elsewhere.Behavior
Unchanged: the removed code was unreachable.
Validation
test_unstructured/partition/pdf_imagepasses (658 passed, 3 skipped).ruff check/ruff format --checkpass.