Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export helpers currently open destinations in write mode before discovering an invalid encoding or an unencodable character. The exception therefore leaves an existing document empty.
Validate encoding incrementally before opening the destination, then keep the existing text-mode write. This protects all staging file exporters against encoding failures with bounded temporary encoded buffers. Operating-system write failures still propagate; this does not claim transactional filesystem writes.
Validation
Seventeen regression cases fail on main; 21 encoding controls pass before and after. All 123 new and staging-base tests pass. Cases cover an unknown codec, a non-ASCII character beyond the first preflight block, existing/new paths, UTF-16 and a stateful Japanese codec. The positional-argument test now uses a Latin-1-encodable multiplication sign, since its previous mocked write concealed a real encoding error. Whole-repository Ruff 0.15.10 lint and format checks pass. Full repository tests remain pending, so this is a draft.