Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pandas converts Excel error cells to missing values before partitioning. That hides displayed
#DIV/0!,#REF!and related results, changes table boundaries, and can discard a sheet containing only errors.Add
include_cell_errors=Truefor XLSX documents. A reader override preserves the displayed error token before Pandas dtype inference, covering both whole-sheet and compacted subtable reads. Blank, numeric, boolean and cached-formula handling stay with the existing reader. The default remains unchanged, and this does not recalculate formulas or change legacy XLS handling.Validation
All 17 new cases fail on main. The new tests, workbook-reader, NA-token and existing XLSX suites pass: 191 passed, two resource-intensive cases deselected. Existing default error-cell expectations still pass. Whole-repository Ruff 0.15.10 lint and format checks pass. Full repository tests remain pending, so this is a draft.
If the worksheet-lifetime PR merges first, pass this option into its direct
open_excel_workbookcall when rebasing.