Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
include_hidden_sheets=Falseto skip hidden and very-hidden XLSX/XLS worksheets. Hidden sheets are skipped before cell parsing while visible sheets retain their original workbook page numbers. The default continues to include every worksheet.Validation
The new filtering cases fail on main. All 24 tests in the hidden-sheet, workbook-reader and NA-token modules pass, including both XLSX traversal modes, default inclusion and XLS visibility states.
Full repository tests remain pending, so this is a draft.
Integration note
This branch is based directly on main. If the worksheet-lifetime change is merged first, apply the same visibility check in its direct reader loop while keeping workbook-index numbering.