Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Google Vision request preparation saves every input image as PNG. Pillow cannot encode CMYK, RGBX, YCbCr or HSV directly, so these inputs fail before reaching the OCR service.
Centralize PNG encoding and convert those color modes through a temporary RGB image. Leave native PNG modes unchanged and preserve the caller's image and language hints. The text, region and layout-element paths all use the same encoder.
Validation
Twelve color-mode cases fail on main, with nine native-PNG controls already passing. All 21 tests pass after the change, decoding actual outgoing PNG bytes and comparing pixels, dimensions, alpha, input ownership and language hints. Whole-repository Ruff 0.15.10 lint and format checks pass. Full repository tests remain pending, so this is a draft.
When rebasing on the single-request Google Vision change, use the shared PNG encoder in its central request helper.