Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOCX ruby annotations hold the document text in
w:rubyBaseand pronunciation inw:rt. Python-docx skips the ruby node, causing the base text to disappear and ruby-only paragraphs to be omitted entirely.Lift the visible base-run content into the enclosing run before partitioning. Text stays in its original position, pronunciation is not duplicated, and tabs and breaks remain available to existing readers. The enclosing run's formatting applies; separate formatting inside the base runs is not resolved.
Validation
All seven regression cases fail on main and pass after the change, covering body, table, header, footer, hyperlink, ruby-only paragraphs and embedded tabs. Whole-repository Ruff 0.15.10 lint and format checks pass. The new tests and existing DOCX suite pass: 229 passed, one long vertical-merge stress case deselected. Full repository tests remain pending, so this is a draft.
Reference: https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.wordprocessing.rubybase