Repository navigation
fix:mouse point issue while changing select field using mouse - #2
Merged
Merged
Conversation
sankarsubramaniankvs
approved these changes
Oct 8, 2026
sankarsubramaniankvs
left a comment
sankarsubramaniankvs
left a comment
There was a problem hiding this comment.
Reviewed the one-file change. The mousedown propagation guard is narrowly scoped to the custom select editor and addresses the described Handsontable outside-click ordering issue without changing value serialization or option rendering. I don't see blockers.
Verification performed:
- Inspected PR metadata/diff and surrounding select editor code.
- Confirmed GitHub check
Server testspassed. - Ran
node --check excel_view/public/js/excel/cell_types/select_cell.jslocally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recorded video
Summary
Fix: Select dropdown ignores mouse click (value reverts)
Problem
In the Excel View grid, choosing an option from a Select cell with the mouse did not
change the value. For example, Lead admission_status New → Valid stayed "New" and saved
"New". Keyboard selection (ArrowDown + Enter) worked.