chore: relevance \b boundaries (housing/tenancy) + Resources visual polish - #116
Open
ltanafranca1004 wants to merge 1 commit into
Open
chore: relevance \b boundaries (housing/tenancy) + Resources visual polish#116ltanafranca1004 wants to merge 1 commit into
ltanafranca1004 wants to merge 1 commit into
Conversation
…olish Two unrelated low-priority fixes bundled per request. relevance filter (events-crawler): - `housing`→`\bhousing` (swallowed by "wareHOUSING") and `tenancy`→`\btenancy` (swallowed by "LieuTENANCY") — the two left-word-boundary offenders the 2026-08-09 sweep missed. Same latent-false-positive class as the earlier lease/rental/renting/tenant/resume fixes. - DROP fixtures + real-word KEEPs added to relevance_test.ts; `deno test` green. - Zero live incidence: 0 rows in public.events match warehousing|lieutenancy; the 5 genuine housing/tenancy rows already ingested still match. Resources visual polish: - CategoryTile: render the category description (existing i18n keys, already used by CategoryView) under the label. - PartnerDetail: fix category-pill contrast — saturated-color-on-10%-tint text failed WCAG for lighter category colors (orange #F68B26, gold #C8941F); now dark ink on the pale tint with a colored dot, matching CategoryTile. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated low-priority fixes bundled into one PR per request.
1. relevance filter — two leftover left-word-boundary bugs
The 2026-08-09 boundary sweep (BACKLOG "terms without a left word boundary", RESOLVED) fixed
lease/rental/renting/tenant/resumebut its "four substrings of common words" tally undercounted. Two more terms inCORE_TERMShad the same latent false-positive bug:housingWarehousing & Distribution CertificatetenancyLieutenancy Awards Ceremonytenancysat directly beside the\btenantfix (same Lieutenant/Lieutenancy root) and was missed. Now\bhousing/\btenancy.Verification (same rigor as the earlier
\bfixes):lib/relevance_test.ts: addedWarehousing…+Lieutenancy…as DROP fixtures andAffordable Housing Forum+Tenancy Rights Q&Aas real-word KEEPs (the boundary must not cost genuine hits).deno test supabase/functions/events-crawler/lib/relevance_test.ts→ 4 passed.public.eventsmatchwarehousing|lieutenancy(nothing ingested is dropped), and the 5 genuine\bhousing/\btenancytitles already ingested still match. Adding\bonly narrows, so this can't add keeps.2. Resources visual polish
CategoryTile): the tiles showed label + org count only. Now they also render the category description, reusingPARTNER_CATEGORY_DESCRIPTION_KEYS(the same keysCategoryViewalready renders),line-clamp-2for grid tidiness. No new i18n keys →check-i18nunaffected (still "parity OK"); ar/fr-CA fall back to EN exactly as the rest of theresources.*block already does.PartnerDetail): the pill rendered saturated category-color text on a 10%-alpha tint of the same color, which fails WCAG AA for the lighter category colors (orange#F68B26, gold#C8941F, teal#2DB39A). Now dark ink (text-ink-secondary) on the defined paletint, with a small colored dot for category identity — matching the already-readableCategoryTiletreatment.Checks
deno test(relevance): 4 passedtsc --noEmit: cleaneslint(changed components): cleancheck-i18n: parity OK🤖 Generated with Claude Code