Skip to content

fix(history): enforce delivery scope availability - #48

Merged
mkdir700 merged 2 commits into
mainfrom
fix/history-delivery-scope-failure
Aug 20, 2026
Merged

fix(history): enforce delivery scope availability#48
mkdir700 merged 2 commits into
mainfrom
fix/history-delivery-scope-failure

Conversation

@mkdir700

Copy link
Copy Markdown
Member

问题

PR #47 已合并后,审查发现发送情况查询仍有三条提前返回路径会绕过当前成员范围检查:未追踪的旧记录、来源缺失记录和远端记录。因此当前成员范围不可用时,这些查询仍可能错误地返回成功。

修改

  • 在确认记录存在后立即检查当前成员范围
  • 所有成功返回路径共用同一次检查结果
  • 本机记录继续复用该结果过滤发送目标
  • 新增三项回归测试覆盖所有提前返回路径
  • 同步架构维护记录

验证

  • cargo test -p uc-application --lib current_peer_scope_is_unavailable --locked -- --nocapture:3 passed
  • cargo test -p uc-application --lib clipboard::sync::get_entry_delivery_view::tests --locked:20 passed
  • cargo test -p uc-application --lib --locked:833 passed
  • cargo check --workspace --all-targets --locked
  • cargo metadata --locked --format-version 1
  • cargo fmt --all -- --check
  • node scripts/architecture/check-engine-repository.mjs
  • git diff --check

审查来源

验证边界

真实双设备流程未执行。

Apply AI Review suggestion
Verified with confidence: 100/100

AI-Review: #47 (comment)
Resolves: #47 (comment)
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@mkdir700, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 57c6bba8-6837-43d4-8a76-0557ecd3765c

📥 Commits

Reviewing files that changed from the base of the PR and between 8203829 and 4247ed9.

📒 Files selected for processing (2)
  • crates/uc-application/src/clipboard/sync/get_entry_delivery_view.rs
  • docs/architecture/architecture-bible.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mkdir700
mkdir700 merged commit 271251b into main Aug 20, 2026
2 checks passed
@mkdir700
mkdir700 deleted the fix/history-delivery-scope-failure branch August 20, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant