Repository navigation
Keep malformed Node and Deno manifests from breaking the dashboard - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A repository with
package.jsoncontainingnullcrashes command detection with an AttributeError. Because dashboard state detects commands for each ready project, one malformed manifest can interrupt the library view.Validate the package/config objects, script/task tables and Node entry-point types before reading them. Invalid metadata is skipped so detection can continue to another supported project type. Valid Deno task objects, including dependency-only tasks, remain supported.
Validation: the complete Python suite ran on Windows with Python 3.14: 99 tests, 98 passed and one platform-specific test skipped. All 31 detection tests passed again after adding coverage for Deno task objects. New regressions cover null/array/scalar manifests, malformed script/task tables and invalid entry-point types.
This is a source fix. The existing v0.2.1 Windows downloads are unchanged; a separately built release is needed to distribute the change.