feat(cli): camelCase the IPC wire DTOs - #1909
Merged
Merged
Conversation
github-actions
Bot
added
test:uipath-langchain
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes consistently update IPC casing, tests, and package metadata.
Review effort: Lite
Findings: None
What changed in this PR
Updates IPC DTO wire fields to camelCase and bumps uipath to 2.14.25.
Changes:
- Renamed runtime and job API DTO fields.
- Updated IPC tests and wire-key assertions.
- Refreshed package metadata and lockfile.
- Removed an obsolete comment.
| File | Summary |
|---|---|
packages/uipath/uv.lock |
Updates the locked package version. |
packages/uipath/tests/cli/test_server_ipc.py |
Updates runtime IPC tests. |
packages/uipath/tests/cli/test_job_api.py |
Updates DTO and wire-key tests. |
packages/uipath/src/uipath/_cli/cli_server_ipc.py |
Renames runtime IPC DTO fields. |
packages/uipath/src/uipath/_cli/cli_run.py |
Removes an obsolete comment. |
packages/uipath/src/uipath/_cli/_job_api.py |
Renames job API DTO fields and mappings. |
packages/uipath/pyproject.toml |
Bumps the package version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
robert-ursu
approved these changes
Sep 23, 2026
Every other handler <-> runtime channel (JS result DTO, both runtimes' config files, output.json) is camelCase; the IPC dataclasses were the odd ones out. The handler reads either spelling and selects this contract by uipath version, 2.14.25 and up.
eduard-dumitru
force-pushed
the
feat/ipc-dto-camelcase
branch
from
September 23, 2026 07:13
27aa040 to
fdc5c81
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The handler talks to its runtimes over a dozen JSON channels (files, HTTP, IPC). All of them are camelCase except the IPC dataclasses in
uipath, which were PascalCase. This aligns the last odd channel so every runtime speaks the same casing.What
cli_server_ipc.py:RunJob/StopJobrequest and reply fields renamed to camelCase._job_api.py: log, result and error DTOs renamed to camelCase.Compatibility
The handler already reads either spelling. It will send camelCase requests only to venvs with
uipath >= 2.14.25and keep the PascalCase contract for older ones (hdens #8031).