feat(agent): block uip codedagent run and function run in uipath_cli tool - #1108
Open
mariadhakalUipath wants to merge 1 commit into
Open
mariadhakalUipath wants to merge 1 commit into
mariadhakalUipath wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add tool-level tests covering prefixed and unprefixed commands and confirming no subprocess is invoked.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
This PR prevents uipath_cli from locally executing codedagent run and function run commands.
Changes:
- Rejects prohibited commands with a recoverable
exit_code=-1000response. - Preserves other coded agent and function subcommands.
- Adds parser tests for blocked commands.
| File | Summary |
|---|---|
tests/agent/tools/internal_tools/test_uipath_cli_tool.py |
Tests parser rejection of blocked commands. |
src/uipath_langchain/agent/tools/internal_tools/uipath_cli_tool.py |
Rejects prohibited run commands before subprocess execution. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+58
to
+61
| @pytest.mark.parametrize("command", ["codedagent run", "function run"]) | ||
| def test_parse_blocks_local_run_commands(command: str) -> None: | ||
| with pytest.raises(ValueError, match="blocked"): | ||
| _parse_uip_command(command) |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.