chore: move the CLA signer procedure into signatures/README.md - #202
Merged
Merged
Conversation
cosmin-staicu
requested review from
alinahornet,
cosminvlad,
litheon,
lucianaparaschivei and
razvalex
as code owners
September 22, 2026 05:53
cosmin-staicu
force-pushed
the
chore/remove-cla-add-signer
branch
from
September 22, 2026 05:54
f4e8bb7 to
8ec775f
Compare
cosmin-staicu
changed the title
2 tasks
The /cla-add-signer command carried steps written down nowhere else: the legal-confirmation stop condition, legalRef being obtained rather than guessed, the case-insensitive duplicate check, JSON validation, never committing to main, and the instruction not to paste the CLA document or personal contact details into the PR. Those reach only maintainers who drive the repository through Claude Code. They are now numbered steps in signatures/README.md, next to the schema they refer to, and the command is removed. Its pointer went with it -- that pointer already named .claude/skills/, a path that does not exist. Nothing else referenced the command, and neither the CODEOWNERS gate on signatures/ nor cla.yml reading the registry depended on it. Also ignores .claude/worktrees/: sessions place throwaway checkouts there, and `git add -A` from the repository root otherwise commits a gitlink to one. Scoped to that directory rather than .claude/, so a command committed there later is not silently ignored. Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
cosmin-staicu
force-pushed
the
chore/remove-cla-add-signer
branch
from
September 22, 2026 06:02
8ec775f to
40b72e0
Compare
cosmin-staicu
changed the title
|
lucianaparaschivei
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
/cla-add-signercarried real procedure, not just a wrapper over "edit the JSON". Steps that existed nowhere else:legalRefis obtained from legal, never guessed;main;All of that reached only maintainers driving the repository through Claude Code.
signatures/README.mdsaid little more than "editcla.jsonby hand".What
The procedure moves into
signatures/README.mdas numbered steps, next to the schema it refers to, and the command is removed. Its pointer goes with it — that sentence already named.claude/skills/, a path that does not exist, since the file lived under.claude/commands/.Nothing else referenced the command (
git grep cla-add-signeris now empty), and nothing about enforcement changes:CODEOWNERSgate onsignatures/still requires maintainer approval and leaves the audit trail;.github/workflows/cla.ymlreads the registry, not the command, solegal/clais unaffected;Also: ignoring agent worktrees
Sessions place throwaway checkouts under
.claude/worktrees/. Nothing ignored them, so agit add -Afrom the repository root picks one up as an embedded git repository and commits a gitlink — a160000entry pointing at a path that exists on one machine and nowhere else. It happened on #196 and had to be backed out.Scoped to that directory rather than
.claude/wholesale. Nothing under.claude/is tracked after this PR, so the broader rule would work today, but it would also mean a command committed there later is silently ignored..claude/settings.local.jsonneeds nothing here; a global ignore already covers it.Verification
git grep cla-add-signerreturns nothing.git statusno longer reports?? .claude/worktrees/with a worktree present, andgit check-ignore -v .claude/worktrees/resolves to the new rule. No build or test surface is touched.Contributor declaration
git commit -s).