SAFIR updates#1502
Conversation
|
Not sure why the It would be best to locally rebase your branch on Truncating sinograms can already be done via |
|
I haven't tried SSRB for our purposes. Does it work with generic geometries as well? |
it won't work for span, but (could be made to) work for trimming and possibly view-mashing
Normally you can, but you will have to force push. Who knows what GitHub will do for the diff now, but worth a try. |
|
the last commit in this PR (b98ce8a) added a massive |
|
ok. didn't even see that! @SomayehSaghamanesh , please remove your build (don't put it in the source dir, or add it to your local |
|
But I thought I had rebased and removed that commit. Are you sure it
doesn't belong to another branch?
…On Wed, Sep 4, 2024, 17:53 Kris Thielemans ***@***.***> wrote:
ok. didn't even see that!
@SomayehSaghamanesh <https://github.com/SomayehSaghamanesh> , please
remove your build (don't put it in the source dir, or add it to your local
.gitignore), rebase, and force-push.
—
Reply to this email directly, view it on GitHub
<#1502 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXA62EOMJF3B5HODTDPRHBTZU4UJNAVCNFSM6AAAAABNULAYIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGQZTOOJWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
clearly not. 5000+ files difference... if you want to drop a commit, easiest is to use interactive rebase I'm afraid. |
|
I did several rebase and looks something went wrong in between. I'll take
care of this.
…On Wed, Sep 4, 2024, 18:13 Kris Thielemans ***@***.***> wrote:
clearly not. 5000+ files difference...
if you want to drop a commit, easiest is to use interactive rebase I'm
afraid.
—
Reply to this email directly, view it on GitHub
<#1502 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXA62EIDTSEXRWD3OPIWFZLZU4WTNAVCNFSM6AAAAABNULAYIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGQ3TSMBXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
SomayehSaghamanesh
force-pushed
the
safir_updates
branch
from
b98ce8a to
998e0c5
Compare
SomayehSaghamanesh
force-pushed
the
safir_updates
branch
from
998e0c5 to
69486f5
Compare
|
I think the git problem is fixed now. |
robbietuk
left a comment
robbietuk
left a comment
There was a problem hiding this comment.
Just a couple of comments. Trimming projdata conversation turned up in #1499 (comment).
I think the two utilities need to be added to https://github.com/UCL/STIR/blob/master/src/utilities/CMakeLists.txt
| \param num_tang_poss_to_trim has to be smaller than the available number | ||
| of tangential positions. |
There was a problem hiding this comment.
It's not clear from this documentation which tangential positions are trimmed, min or max tangential positions?
There was a problem hiding this comment.
The trim should be symmetric. I can include in the documentation.
Yes, two utilities should be included in the CMakeLists indeed. just ignored to be tracked locally. I'll do it.
SomayehSaghamanesh
force-pushed
the
safir_updates
branch
from
c3372b2 to
8ae5dd5
Compare
…into safir_updates
4 participants
Changes in this pull request
Added two models of SAFIR scanners (generic geometry) to stir's scanners list.
Added two utilities to convert and trim projections.
Testing performed
STIR-6 build tests were performed successfully without any error. Tests for SAFIR I/II data conversion and image reconstructions were performed successfully.
Related issues
issue #1501
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)