fix: add .js extension to fast-deep-equal ESM import#2641
Conversation
…atibility The Next.js server-util test failed because fast-deep-equal has no exports field, so Node.js ESM requires the explicit .js extension to resolve the file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the import path for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
Summary
Fixes the CI failure introduced by d8fb6c2 (Next.js server-util integration test) by adding the
.jsextension to thefast-deep-equal/es6/reactimport in@blocknote/react.Rationale
The
fast-deep-equalpackage has noexportsfield in itspackage.json, so Node.js ESM strictly requires the.jsfile extension to resolve subpath imports. The Next.js test app runs under ESM, causingERR_MODULE_NOT_FOUNDat runtime.Changes
.jsextension tofast-deep-equal/es6/reactimport inpackages/react/src/hooks/useEditorState.tsImpact
No impact on existing bundler-based consumers (Webpack, Vite, etc.) since they already resolve extensionless imports. This change only affects Node.js ESM resolution, fixing the server-util test.
Testing
@blocknote/reactand verified the dist output contains the corrected import path with.jsextension.Checklist
Summary by CodeRabbit