enhance: Codex向けLAN HTTPS開発環境を追加 - #25
Conversation
|
Warning Review limit reached
Next review available in: 34 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac2d9ad18d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const config = yaml.load(await fsp.readFile(sourceConfigPath, 'utf-8')) ?? {}; | ||
| config.url = 'https://misskey.local/'; |
There was a problem hiding this comment.
Require a setup password before publishing to the LAN
On a fresh worktree/database, this copies .config/example.yml, where setupPassword is commented out, and the Run action subsequently exposes the instance through Portless LAN mode. In that state, admin/accounts/create explicitly accepts an unauthenticated request as the first administrator when config.setupPassword is unset, so another device on the LAN can claim the new instance before the developer does. Generate a per-environment setup password in the ignored config and present it to the developer before allowing the LAN server to start.
Useful? React with 👍 / 👎.
What
pnpm devの HMR を有効化Why
複数の Codex Environment を同時に立ち上げてもデータベースや Portless が競合せず、LAN 内の別端末から HTTPS で開発中の Misskey を確認できるようにするためです。
Additional info (optional)
初回のみ
Prepare LAN HTTPSアクションで mDNS ツールの導入とローカル CA の信頼設定を行います。PostgreSQL と Redis は127.0.0.1:5432/127.0.0.1:6379の既存サービスを利用します。動作確認:
wss接続Checklist