Skip to content

Windows cross-process session lock test is skipped on Windows #1104

Description

@PierrunoYT

Found in the 2026-09-28 code audit (finding N-9).

Where: internal/sessions/rewind_test.go:356-358 (t.Skip("flock semantics differ on windows")); implementation internal/sessions/filelock_windows.go.

Problem: The only test of the LockFileEx path never runs on the platform that uses it. Related skips: oauth/store_test.go:79, config/writer_test.go:128,222.

Suggested fix: port lockutil's helper-process test (lockutil_test.go:162,206), or migrate sessions onto lockutil (the audit lists seven duplicated file-lock implementations; only lockutil has the #950 hardening).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions