Repository navigation
fix(clone): copy a __proto__ member instead of assigning through the setter - #3175
Open
suraiya-ctrl wants to merge 1 commit into
Open
suraiya-ctrl wants to merge 1 commit into
suraiya-ctrl wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@turf/clonecopies every input key withcloned[key] = value. When the GeoJSON came fromJSON.parseand has a member literally named__proto__(an ordinary own property on parsed objects), that assignment hits theObject.prototype.__proto__setter on the fresh clone instead of copying the member:cloneProperties: the returned properties object gets the input value as its prototype, socloned.properties.xreads keys the original never exposed andObject.keysdoes not showcloneFeature/cloneFeatureCollection: the foreign-member loop does the same, and the prototype is the very same object reference as the input, so the clone is not independent of itclone(f)is no longer deeply equal tofThe effect stays on the returned object (the global
Object.prototypeis not touched), but any consumer that clones untrusted GeoJSON and then reads properties by name gets attacker-chosen values back. A__proto__key is now defined withObject.definePropertyas a plain own property, the same way lodash'sbaseAssignValuehandles it. Not a breaking change. The new tape test fails on master and passes with the fix.contributorsfield ofpackage.json: left out to keep the diff to the fix, happy to add.