Repository navigation
break(meta) BREAK Improve propEach TypeScript signature - #3162
Merged
Merged
Conversation
- Tighten `geojson` parameter type signatures to only Feature and FeatureCollection - Improve inference of `currentProperties` argument in callback - Expose `false` return from callback to TypeScript - Remove @ts-expect-errors - Modernize the loop syntax
mfedderly
added
@turf/meta
backwards incompatible
mfedderly
changed the title
mfedderly
commented
Sep 7, 2026
| propEach(features, (prop) => prop); | ||
| meta.propEach(features, (prop) => prop); | ||
| meta.propEach(poly, (prop, index) => prop); | ||
| meta.propEach<{ bar: string }>(poly, (prop) => prop.bar); |
Collaborator
Author
There was a problem hiding this comment.
This props cast actually became an error because it knew that poly did not have those props. I cast the argument instead so that we can still test the inference of prop in the callback.
mfedderly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geojsonparameter type signatures to only Feature and FeatureCollectioncurrentPropertiesargument in callbackfalsereturn from callback to TypeScriptPerf changes are essentially neutral from this.