Repository navigation
feat(turbodocx-sdk): optional pageNavigation for embedded signing URLs - #42
Draft
nicolasiscoding wants to merge 2 commits into
Draft
nicolasiscoding wants to merge 2 commits into
nicolasiscoding wants to merge 2 commits into
Conversation
…gning URLs createSigningUrl and createEmbeddedSignature take an optional pageNavigation (auto | collapsed | hidden) that sets how the embedded signing page shows its page thumbnails inside the iframe. Shown as a commented option in every language reference with the per-language name and type, plus a note that it applies per URL and must be passed again when re-minting a pending signer. Follows TurboDocx/SDK#132.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Follows TurboDocx/SDK#132, which adds the optional
pageNavigationoption tocreateSigningUrlandcreateEmbeddedSignaturein all six SDKs.Merge order: merge this after SDK#132 ships in a release. Until then, generated Go, Java and PHP code that sets the option will not compile against the current published SDK (the Java reference pins
0.9.0). Bump the pins in the same release follow-up.Description
pageNavigationsets how the embedded signing page shows its page navigation (the thumbnail rail and the "Pages" button) inside the integrator's iframe:auto(default) sizes it to the iframe width.collapsedstarts the rail collapsed. The signer can still open it.hiddenremoves the rail and the Pages button.The setting applies to one URL only. Omitting it on a later mint resets the navigation to
auto.This PR documents the option in every language reference. It appears as a commented, optional line next to
returnUrl, so generated code does not set it by default.pageNavigation: 'hidden'(PageNavigationMode)pageNavigation: 'hidden'page_navigation="hidden"page_navigation="hidden"PageNavigation: turbodocx.PageNavigationHiddenCreateEmbeddedSignatureRequestpageNavigation: PageNavigation::HIDDEN(enum, not a string).pageNavigation(PageNavigation.HIDDEN)page_navigation: "hidden"keywordpageNavigation: "hidden"request-hash keyEach reference also says:
pendingsigner aftercreateEmbeddedSignaturehas to pass it again.?PageNavigation, so a plain string is aTypeError. OnlyfromArray()accepts strings, and it throwsInvalidPageNavigationfor any other value.SKILL.mdadds one sub-bullet to the embedded-signing guidance. It tells the model to set the option only when the user asks to hide or collapse the page navigation, and gives the name to use in each language.Evals
There are six new cases, ids 72 to 77, one per language. They mix
hiddenandcollapsed, andcreateSigningUrlandcreateEmbeddedSignature. Each asserts that the option is passed with the correct name and type for that language. Case 72 also asserts the option is not attached to the browser widget or the URL. Case 74 asserts every mint sets it.How they were run
claude evals runis not an available command, andclaude plugin evalexpectscase.yamlsuites. So I used the skill-creator flow:main's skill.mainskillpageNavigationwhen the prompt didn't ask for itNot run: the other 66 existing cases. Their skill sections did not change.
Not compiled: none of the generated code was compiled or executed.
🤖 Generated with Claude Code