Repository navigation
chore(example): use @turbodocx/sdk ^0.9.0 in the embedded web app - #130
Merged
Merged
Conversation
^0.8.0 excludes 0.9.0. 0.9.0 types sendSignature's recipients as always present, so the (sent.recipients ?? []) guard goes too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The embedded web app example depends on
@turbodocx/sdk ^0.8.0, which doesn't allow 0.9.0. This bumps it to^0.9.0(lockfile now resolves 0.9.0 from npm). 0.9.0 typesrecipientsas always present onsendSignature, so the(sent.recipients ?? [])guard inhandlers.tsis removed (the follow-up flagged in #107).The lockfile was updated with
--legacy-peer-depsbecause of a peer conflict already on main (@vitejs/plugin-react@4.7doesn't list vite 8), unrelated to this change. That also flips four entries fromdevOptionaltodev.Checks
tsc --noEmit: clean on SDK 0.9.0vitest run: 18 passed🤖 Generated with Claude Code