Repository navigation
docs(turbosign): say embedded verification is recommended, not enforced - #218
Merged
Merged
Conversation
Contributor
Author
|
Self-review (author). No blocking issues found. Checked:
Nits, optional:
|
amitsharma-turbodocx
force-pushed
the
fix/215-verification-not-enforced
branch
from
October 21, 2026 09:10
cbd8687 to
33ecec6
Compare
…ed (#215) With no verification on a recipient and an org that verifies only when requested, TurboSign still issues a reusable signing link. Reword the two spots that said every embedded signer needs a method, add a caution, and link to the identity-verification warning that already says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
amitsharma-turbodocx
force-pushed
the
fix/215-verification-not-enforced
branch
from
October 21, 2026 09:36
33ecec6 to
9982b52
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #215
Why
embedded-signing/index.mdand the sharedbuild/_setup-and-verify.mdxsaid "Every embedded signer needs a verification method". A developer reads that as enforced. It isn't, by design: on an org that verifies only when requested, a recipient with noauth/otpChannelgets a reusable signing link. A forgottenauththerefore silently yields an unprotected link. The identity-verification page andreference.mdalready said so. These two spots disagreed with them.What
index.md: "Give every embedded signer a verification method." plus a caution, "TurboSign does not enforce this". It covers the reusable link on "Only when requested" orgs and the default method on "On every signature request" orgs, and links to the existing warning._setup-and-verify.mdx(rendered in all four build guides): the same point in one sentence, with the same link.Verified
Against a local TurboDocx API and the built site:
defaultChannel: none), recipient with noauth:createSigningUrlreturns a URL withmode: nullandpendingChecks: [].email), same recipient:mode: otp,pendingChecks: ["email_otp"].identity-verification#signers-in-your-own-app-embedded-signing.docusaurus buildpasses, with no new broken anchors.🤖 Generated with Claude Code