Support local shared CSS in root dev flow

[minimaluminium]

Summary

• resolve @tryghost/shared-theme-assets CSS imports to local packages/_shared during root yarn dev
• keep build/zip/release paths on pinned package resolution

Testing

• node --check gulpfile.js

[coderabbitai]

Walkthrough

The PR introduces local resolution of @tryghost/shared-theme-assets imports in the build system. A new PostCSS plugin (localSharedAssetsImport) rewrites theme asset import paths to point at local files under packages/_shared. The CSS build pipeline is centralized through a cssPlugins() function that conditionally enables the new plugin before existing processors. Theme builds now accept options to enable the feature, with main() calling buildTasksForTheme() with {useLocalSharedAssets: true}, and both shared CSS build steps (sharedCSS_v1, sharedCSS_v2) using the configurable pipeline.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: enabling local shared CSS resolution in the root development flow, which matches the core objective of the pull request.
Description check	✅ Passed	The description is directly related to the changeset, explaining the purpose (resolve local CSS imports during dev) and scope (keep build/release paths unchanged), along with testing approach.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/local-shared-dev-css

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/episode/assets/built/screen.css`:
- Line 1: The share controls lost their full styling during the build—restore
the missing share UI stylesheet (the CSS that defines .gh-button-share and
related share-control rules) so .gh-button-share and any share-related classes
regain their visual/interactive styles, or if the share markup was intentionally
removed, delete the .gh-button-share usage from templates/components instead;
look for references to .gh-button-share and the share controls in the built CSS
and the corresponding share markup to either re-import the original share
stylesheet or remove the classes/markup consistently.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b0dfcdc7-f68e-4d53-9bfa-be01089a14a2

📥 Commits

Reviewing files that changed from the base of the PR and between 8ffe3c5 and f4b2ff1.

⛔ Files ignored due to path filters (16)

• packages/alto/assets/built/screen.css.map is excluded by !**/*.map
• packages/bulletin/assets/built/screen.css.map is excluded by !**/*.map
• packages/dawn/assets/built/screen.css.map is excluded by !**/*.map
• packages/digest/assets/built/screen.css.map is excluded by !**/*.map
• packages/dope/assets/built/screen.css.map is excluded by !**/*.map
• packages/ease/assets/built/screen.css.map is excluded by !**/*.map
• packages/edge/assets/built/screen.css.map is excluded by !**/*.map
• packages/edition/assets/built/screen.css.map is excluded by !**/*.map
• packages/episode/assets/built/screen.css.map is excluded by !**/*.map
• packages/headline/assets/built/screen.css.map is excluded by !**/*.map
• packages/journal/assets/built/screen.css.map is excluded by !**/*.map
• packages/london/assets/built/screen.css.map is excluded by !**/*.map
• packages/ruby/assets/built/screen.css.map is excluded by !**/*.map
• packages/solo/assets/built/screen.css.map is excluded by !**/*.map
• packages/taste/assets/built/screen.css.map is excluded by !**/*.map
• packages/wave/assets/built/screen.css.map is excluded by !**/*.map

📒 Files selected for processing (17)

• gulpfile.js
• packages/alto/assets/built/screen.css
• packages/bulletin/assets/built/screen.css
• packages/dawn/assets/built/screen.css
• packages/digest/assets/built/screen.css
• packages/dope/assets/built/screen.css
• packages/ease/assets/built/screen.css
• packages/edge/assets/built/screen.css
• packages/edition/assets/built/screen.css
• packages/episode/assets/built/screen.css
• packages/headline/assets/built/screen.css
• packages/journal/assets/built/screen.css
• packages/london/assets/built/screen.css
• packages/ruby/assets/built/screen.css
• packages/solo/assets/built/screen.css
• packages/taste/assets/built/screen.css
• packages/wave/assets/built/screen.css

[coderabbitai]

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Share controls appear partially unstyled after rebuild.

Line 1 keeps .gh-button-share usage but only minimal declarations remain, with base visual/interactive share-button styling removed. This is a user-facing regression and not just a build-path refactor. Please restore the missing share UI stylesheet import (or remove the corresponding markup/classes if intentional) before merge.

🧰 Tools

🪛 Stylelint (17.12.0)

[error] 1-1: Deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated)

(declaration-property-value-keyword-no-deprecated)

---

[error] 1-1: Deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated)

(declaration-property-value-keyword-no-deprecated)

---

[error] 1-1: Deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated)

(declaration-property-value-keyword-no-deprecated)

---

[error] 1-1: Deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated)

(declaration-property-value-keyword-no-deprecated)

---

[error] 1-1: Deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated)

(declaration-property-value-keyword-no-deprecated)

---

[error] 1-1: Deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated)

(declaration-property-value-keyword-no-deprecated)

---

[error] 1-1: Expected quotes around "Mona Sans" (font-family-name-quotes)

(font-family-name-quotes)

---

[error] 1-1: Expected "to" to be "100%" (keyframe-selector-notation)

(keyframe-selector-notation)

---

[error] 1-1: Expected "to" to be "100%" (keyframe-selector-notation)

(keyframe-selector-notation)

---

[error] 1-1: Expected "BlinkMacSystemFont" to be "blinkmacsystemfont" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Segoe" to be "segoe" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "UI" to be "ui" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Helvetica" to be "helvetica" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Arial" to be "arial" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Georgia" to be "georgia" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Menlo" to be "menlo" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Consolas" to be "consolas" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Monaco" to be "monaco" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Liberation" to be "liberation" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Mono" to be "mono" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Lucida" to be "lucida" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "Console" to be "console" (value-keyword-case)

(value-keyword-case)

---

[error] 1-1: Expected "currentColor" to be "currentcolor" (value-keyword-case)

(value-keyword-case)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/episode/assets/built/screen.css` at line 1, The share controls lost
their full styling during the build—restore the missing share UI stylesheet (the
CSS that defines .gh-button-share and related share-control rules) so
.gh-button-share and any share-related classes regain their visual/interactive
styles, or if the share markup was intentionally removed, delete the
.gh-button-share usage from templates/components instead; look for references to
.gh-button-share and the share controls in the built CSS and the corresponding
share markup to either re-import the original share stylesheet or remove the
classes/markup consistently.

[coderabbitai]

🧹 Nitpick comments (1)

gulpfile.js (1)

38-39: 💤 Low value

Consider warning if sourceFile is unavailable.

The fallback to __dirname on line 39 would produce incorrect relative paths because __dirname is the repo root, not the CSS file's directory. In practice, source.input.file should always be populated during CSS processing, but if it's ever undefined (e.g., processing in-memory strings), the relative path would be wrong.

🛡️ Optional: add a warning for defensive clarity

         const [, quote, assetPath, trailingParams] = match;
         const sourceFile = atRule.source?.input?.file;
+        if (!sourceFile) {
+            console.warn('[localSharedAssetsImport] sourceFile unavailable, using fallback - relative path may be incorrect');
+        }
         const sourceDir = sourceFile ? path.dirname(sourceFile) : __dirname;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@gulpfile.js` around lines 38 - 39, The code falls back to __dirname when
atRule.source?.input?.file is undefined, which yields incorrect relative paths;
update the logic around sourceFile and sourceDir (the atRule variable and the
sourceFile/sourceDir assignment) to detect when sourceFile is missing and (1)
avoid silently using __dirname by instead setting sourceDir to null or a safe
placeholder, (2) emit a console or logger warning that source.input.file is
unavailable and relative path resolution may be incorrect, and (3) guard
downstream path.dirname or path.join usages to handle the null/placeholder case
so no incorrect repo-root paths are produced.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@gulpfile.js`:
- Around line 38-39: The code falls back to __dirname when
atRule.source?.input?.file is undefined, which yields incorrect relative paths;
update the logic around sourceFile and sourceDir (the atRule variable and the
sourceFile/sourceDir assignment) to detect when sourceFile is missing and (1)
avoid silently using __dirname by instead setting sourceDir to null or a safe
placeholder, (2) emit a console or logger warning that source.input.file is
unavailable and relative path resolution may be incorrect, and (3) guard
downstream path.dirname or path.join usages to handle the null/placeholder case
so no incorrect repo-root paths are produced.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21f89c35-0d7b-4969-90cd-208020506c7b

📥 Commits

Reviewing files that changed from the base of the PR and between f4b2ff1 and 95f7e81.

📒 Files selected for processing (1)

• gulpfile.js