You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The overrides added in #2416 cost more to maintain than the alerts they
cleared. Renovate treats each override value as a range to raise, and it
has already widened the srvx cap once (#2418) and proposed moving Fedify
onto srvx 1.x and @opentelemetry/sdk-metrics 3.x (#2420, #2419). Each of
those puts Fedify on versions it doesn't support, in code CI doesn't
exercise.
Neither vulnerable path runs in our service, so going back to the
versions Fedify asks for doesn't expose anyone:
@opentelemetry/core 2.7.1 is only used inside sdk-metrics. Nothing
registers its W3C baggage propagator; Sentry installs its own.
srvx only comes in through @fedify/cli, a dev dependency that isn't in
the production image.
The alerts will be dismissed as not applicable, and the pins go away
when Fedify updates its dependencies.
ref https://github.com/TryGhost/ActivityPub/security/dependabot/197
ref https://github.com/TryGhost/ActivityPub/security/dependabot/195
The overrides added in #2416 cost more to maintain than the alerts they
cleared. Renovate treats each override value as a range to raise, and it
has already widened the srvx cap once (#2418) and proposed moving Fedify
onto srvx 1.x and @opentelemetry/sdk-metrics 3.x (#2420, #2419). Each of
those puts Fedify on versions it doesn't support, in code CI doesn't
exercise.
Neither vulnerable path runs in our service, so going back to the
versions Fedify asks for doesn't expose anyone:
- @opentelemetry/core 2.7.1 is only used inside sdk-metrics. Nothing
registers its W3C baggage propagator; Sentry installs its own.
- srvx only comes in through @fedify/cli, a dev dependency that isn't in
the production image.
The alerts will be dismissed as not applicable, and the pins go away
when Fedify updates its dependencies.
No actionable comments were generated in the recent review.
Walkthrough
The workspace configuration removes the overrides for @opentelemetry/sdk-metrics and srvx, along with comments describing their Fedify 2.4.5 dependency constraints.
TryGhost/ActivityPub#2351: Updated Fedify packages to version 2.4.5, the dependency state described by the removed override comments.
Merge Risk: Minimal · up to c55d1
This change removes dependency overrides that Renovate was widening to versions Fedify does not support. No runtime code changes, and nothing in the supplied evidence shows a concrete merge-blocking risk.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: removal of the Fedify dependency overrides.
Description check
The description explains why the overrides are removed and identifies the affected dependencies and related alerts.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: ede87b14-17af-4e76-8dea-cc8903886992
Commits
Reviewing files that changed from the base of the PR and between aeba2d4 and c55d12f.
Files ignored due to path filters: 1
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 1
pnpm-workspace.yaml
Files with no reviewable changes: 1
pnpm-workspace.yaml
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://github.com/TryGhost/ActivityPub/security/dependabot/197
ref https://github.com/TryGhost/ActivityPub/security/dependabot/195
The overrides added in #2416 cost more to maintain than the alerts they
cleared. Renovate treats each override value as a range to raise, and it
has already widened the srvx cap once (#2418) and proposed moving Fedify
onto srvx 1.x and @opentelemetry/sdk-metrics 3.x (#2420, #2419). Each of
those puts Fedify on versions it doesn't support, in code CI doesn't
exercise.
Neither vulnerable path runs in our service, so going back to the
versions Fedify asks for doesn't expose anyone:
registers its W3C baggage propagator; Sentry installs its own.
the production image.
The alerts will be dismissed as not applicable, and the pins go away
when Fedify updates its dependencies.