Skip to content

Review: switch between saved screen and camera takes - #21

Merged
FernandoAbishai merged 1 commit into
mainfrom
feature/p1-paired-source-review
Oct 23, 2026
Merged

FernandoAbishai merged 1 commit into
mainfrom
feature/p1-paired-source-review

Conversation

@FernandoAbishai

Copy link
Copy Markdown
Member

Scope

  • The post-recording review card now exposes Screen and Camera choices only when both independently playable saved sources exist.
  • Selecting a source changes the AVPlayer item and the Review/Edit destination to that exact file; a missing selected source safely falls back to the remaining saved file.
  • This is explicitly a one-source-at-a-time review, not synchronized PiP or an audio/video alignment claim. Source MOV files, edit recipes, and capture timing metadata are unchanged.

Validation

  • 7 focused PostRecordingPreviewTests passed, including selection of each source, removal of one source, preservation of original bytes.
  • Final ./test.sh --quiet with Xcode 27.1 passed: 518 Python/MCP tests (11 skipped), 665 Swift tests (133 suites), 10 timed Swift tests (8 suites).
  • Swift syntax parse and git diff checks passed.

Release and physical limitations

  • No release, automatic export, installation, or destructive operations.
  • Actual camera+screen synchronization, composite playback and real-hardware UX remain separately gated; tests establish only exact source routing in this slice.

@FernandoAbishai
FernandoAbishai marked this pull request as ready for review October 23, 2026 08:29
Copilot AI balanced review requested due to automatic review settings October 23, 2026 08:29
@FernandoAbishai
FernandoAbishai merged commit d17f27f into main Oct 23, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T08:30:34.842166Z dbe1cff Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants