Repository navigation
P1: Navigate screen recording markers in timeline - #19
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Recording markers were persisted beside screen takes but invisible while cutting video. Timeline Editor now shows small, accessible marker pins on the time ruler and lets the user click a pin to seek directly to that occurrence in the edited output.
Validation
./test.sh --quieton exact commitc02cb9a: 513 Python/MCP tests (11 skipped), 654 Swift tests, 10 timing-sensitive Swift tests passed.git diff --checkand Swift syntax parsing: passed.CI build timeout correction
The first PR CI attempt (run 39899631840) passed the full test job, but the app build was canceled by the existing 10-minute job timeout. Swift Release compilation itself completed successfully in 273.25s. The optional Metal-powered search helper was then running with its output redirected to a build log; GitHub terminated the entire job after 10 minutes, before packaging/signature verification. This was a CI timeout, not a reported compiler failure.
Commit
70b028cgives the macOS build job a bounded 25-minute window and records start/end timing for the Metal helper stage. Previous successfulmainrun 39897937952 took approximately 7 minutes for the same job, with variable cold-build overhead. Bash syntax, workflow YAML structure, andgit diff --checkpassed. The current-head GitHub test/build checks remain the final merge gate.Review / next steps
This is the second small P1 slice after deterministic direct rendering. No automatic edits or publish action were added. Real-device clicking in a session with recorded screen markers remains an interactive UI smoke gate; renderer-clock projection and synthetic media were tested. CI must pass for this exact head before merge. No release requested.