Repository navigation
P1: Render timeline drafts through deterministic local jobs - #18
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Clicking Render edit in the Cutmark timeline previously sent a free-form chat request containing the selected cut operations. Whether and how those operations were applied depended on the agent interpreting the instruction. The timeline now passes an exact structured request to the existing Cutmark render planner and starts an unpublished render job directly.
plan_timeline_editbeforerender_editstarts.publish_edit.SIGPIPEwhen Python exits early. Its reply is a bounded private file (no pipe-EOF dependency), with a SIGTERM then SIGKILL timeout for nonresponsive helpers. The temporary request and reply are removed.Validation
python3 -m unittest discover -q -s mcp/tests -p test_timeline_editing.py: 14 passed, including one real synthetic screen-video render that leaves source media/session metadata untouched.swift test --filter 'TimelineRenderTests|EditTimelineTests' --no-parallel: 19 passed, including early-exit and deliberately SIGTERM-ignoring stalled helper regression tests../test.sh --quieton commit784eeb5: 513 Python/MCP tests (11 skipped), 648 Swift tests, 10 timing-sensitive Swift tests — passed. CI must also pass for the exact PR head before merge.git diff --check, Swift syntax, Python syntax: passed.Scope and review gate
This is the first P1 slice. It reuses current checked render / Jobs machinery and adds no hosting, agent/provider dependency, automatic publishing, screen/camera composition, or new media editing effects. The live timeline button still needs interactive verification against a sample session in a disposable library on a Mac; compilation/tests alone are not physical recording-validation evidence.
Review the Python CLI process boundary, timeout handling, raw-vs-published recipe behavior, and Jobs visibility. CI must pass for the exact PR commit before merge. No release is being requested.