Skip to content

P1: Render timeline drafts through deterministic local jobs - #18

Merged
FernandoAbishai merged 1 commit into
mainfrom
feature/p1-deterministic-render
Oct 23, 2026
Merged

FernandoAbishai merged 1 commit into
mainfrom
feature/p1-deterministic-render

Conversation

@FernandoAbishai

Copy link
Copy Markdown
Member

Problem and behavior

Clicking Render edit in the Cutmark timeline previously sent a free-form chat request containing the selected cut operations. Whether and how those operations were applied depended on the agent interpreting the instruction. The timeline now passes an exact structured request to the existing Cutmark render planner and starts an unpublished render job directly.

  • A raw recording sends its canonical initial recipe. A published edit sends its base and ordered draft actions, which are independently validated by plan_timeline_edit before render_edit starts.
  • Original takes and published recipes remain untouched. The result appears as a background job for the user to review; this path does not call publish_edit.
  • The app rejects stale/tampered drafts, exposes render startup errors, prevents accidental duplicate button clicks, and clears stale job messages after further edits.
  • The helper receives JSON through private, file-backed stdin; this avoids SIGPIPE when Python exits early. Its reply is a bounded private file (no pipe-EOF dependency), with a SIGTERM then SIGKILL timeout for nonresponsive helpers. The temporary request and reply are removed.

Validation

  • python3 -m unittest discover -q -s mcp/tests -p test_timeline_editing.py: 14 passed, including one real synthetic screen-video render that leaves source media/session metadata untouched.
  • swift test --filter 'TimelineRenderTests|EditTimelineTests' --no-parallel: 19 passed, including early-exit and deliberately SIGTERM-ignoring stalled helper regression tests.
  • Final ./test.sh --quiet on commit 784eeb5: 513 Python/MCP tests (11 skipped), 648 Swift tests, 10 timing-sensitive Swift tests — passed. CI must also pass for the exact PR head before merge.
  • git diff --check, Swift syntax, Python syntax: passed.

Scope and review gate

This is the first P1 slice. It reuses current checked render / Jobs machinery and adds no hosting, agent/provider dependency, automatic publishing, screen/camera composition, or new media editing effects. The live timeline button still needs interactive verification against a sample session in a disposable library on a Mac; compilation/tests alone are not physical recording-validation evidence.

Review the Python CLI process boundary, timeout handling, raw-vs-published recipe behavior, and Jobs visibility. CI must pass for the exact PR commit before merge. No release is being requested.

@FernandoAbishai
FernandoAbishai marked this pull request as ready for review October 23, 2026 03:59
Copilot AI balanced review requested due to automatic review settings October 23, 2026 03:59
@FernandoAbishai
FernandoAbishai merged commit 57b1ee2 into main Oct 23, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T04:00:40.626802Z 784eeb5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants