Repository navigation
P0: Make agent setup explicit and preserve installed skills - #17
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Problem and resulting behavior
On a fresh Mac, welcome showed an Install button labeled Claude Code even though setup had no selected installer; clicking it did nothing. Startup skill setup also deleted user-customized same-name skill folders before copying bundled versions. The welcome screen's last page additionally clipped its header/footer whenever setup was incomplete.
This PR requires explicit agent selection, preserves every existing user skill folder, and keeps first-run actions visible throughout setup.
Changes
Validation
OnboardingShots.pages,OnboardingTests,SetupTests, andAgentSetupTests: 29 tests in 5 suites passed (on final tree).CUTMARK_REQUIRE_EMBED=1, native Mach-O checks, and ad-hoc signing. Verified the exact-headf7f0c12Cutmark.appbundle and embeddedcutmark-embedhelper usingcodesign --verify --deep --strict. App was built only in an isolated worktree, never installed over the user's app.git diff --check: passed.f7f0c12: CI run 39891625430 passed (complete tests in 12m46s, signed app build in 3m13s).build.shcompleted locally, requiring the Metal semantic-search helper, with ad-hoc signing and native-binary checks. VerifiedCutmark,cutmark-faces, andcutmark-embedare present;codesign --verify --deep --strictpassed. Neither the installed app nor user recordings were replaced.Scope and release gate
There is no automatic overwrite or upgrade of previously installed skills. A future explicit, user-reviewed migration may be designed for updating them. Existing installed-but-signed-out providers continue through the Sign in path; the chooser targets first-run Macs with no installed runner.
Current-head full CI and local visual onboarding validation are green, and the isolated app bundle passed packaging/signature verification. The PR is ready for review. A final interactive installation walkthrough on a truly fresh macOS user account has not been performed; no production installation, merge, or release is part of this PR update.